xobust / Project-Broban

ProjInda15 project

5 stars 2 forks source link

Feature/player direction #70

Closed willwull closed 8 years ago

willwull commented 8 years ago

Hey y'all, so I continued @xobust's work and added a new sprite sheet for the player that has 4 directions.

Let me know what you guys think of my implementation in Player.Draw, I'm not sure if my solution with the switch statement is the most elegant one.

66

xobust commented 8 years ago

:+1:

willwull commented 8 years ago

I haven't checked out #69 in detail, but will the code in that one affect this if we merge #69?

xobust commented 8 years ago

No it won't but maybe we will use a texture atlas for the player later. Your switch solution looks fine. A shorter version would be to just cast PlayerDirection to an int. ((int)PlayerDirection) since the underlaying enum has int values from 0 to 4 in the order they were typed in:

Up = 0
Down=1
Left=2
Right=3

iRobsc commented 8 years ago

This looks good to me