search

xoceanmodel / xroms

Work with ROMS ocean model output with xarray
https://xroms.readthedocs.io/
MIT License
62 stars 39 forks source link

stratification_frequency only returns 'inner' w-points #1

Open hetland opened 4 years ago

hetland commented 4 years ago

The vertical coordinate in stratification frequency requires quite a bit of wrangling, dropping and replacing vertical coordinates. This part could be re-written to be simpler and more clear. I hope @dcherian could help with this.

The recombined resulting DataArray is on vertical w-points, as it should be, but only the inner points are defined. This will make it difficult to work well with other ROMS DataArrays that are defined on the 'outer' vertical points by default. It would be better to extrapolate values to the surface and bottom, or replace these with boundary values (i.e., zero at the bottom).

kthyng commented 1 year ago

Hi @hetland! I've recently put out a new version to PyPI (v0.2.4, still coming through on conda-forge). Please check to see if this issue is still present in the new version so that over time we can work to address these. Thanks!