xod-wow / LiteMount

World of Warcraft addon LiteMount
GNU General Public License v2.0
27 stars 9 forks source link

Limit combat macro to keybinds? #219

Open Chamlotte opened 3 months ago

Chamlotte commented 3 months ago

For a long while i've used combat macro and it's been very good, up until Fyraak. It took a while to figure out that having a combat macro made the workaround, well, not work.

Would it be possible to have combat macro only apply when using a specific keybind, instead of all of them? I feel this would be a good futureproof way for any other fights like this, so i can just use another keybind to mount when using combat macro to roll or ghost wolf.

mbattersby commented 3 months ago

Hi there,

Blizzard are removing the ability for addons like LIteMount to run macros in TWW, so the combat macro, unavailable macro and some of the more complex LiteMount functionality will be going away. Or perhaps the whole addon, depending on what they decide to add back or not from the current Alpha state.

Given that, I'm not really putting any new dev work into LiteMount for now. I suggest it is probably a good time to get used to not having the combat macro at all.

Sad times.

mbattersby commented 3 months ago

See https://github.com/Stanzilla/WoWUIBugs/issues/552

Chamlotte commented 3 months ago

Thanks, this is sad lookin news indeed. Here's hoping someone decides it's actually just a bad idea and reverts.

mbattersby commented 3 months ago

Out of interest (and future problems aside), can you explain a different way? I don't really understand your issue.

I assume you are talking about Tindral Sageswift (not Fyrakk), otherwise I'm even more confused.

In the Tindral Sageswift fight, you can mount in combat with the buff from the feather. You are still in combat the whole time though, when LiteMount can't do anything. All it can do it set up the keybind action before combat so it will do a specific thing if you activate it during that combat.

What is does at the moment is, if you have a combat macro set and enabled it uses that. If you don't and you're in the Tindral Sageswift area (based on the map) it sets the action to mount a dragonriding mount. Otherwise it uses the default combat actions (dismount, leavevehicle, cancelform).

I'm not sure which part you think is the "bug". Did you expect it to run your combat macro, or use a dragonriding mount? It can only do one or the other for the whole fight, it can't switch between.

You can easily set up your own combat macro to do the right thing based on the Blizzard macro conditions. E.g.,

/cast [mod:alt] Voyaging Wilderling
Chamlotte commented 3 months ago

Apologies for the mixup.

As litemount has several different binds, what i meant to suggest was having the combat macro active for one bind, and inactive for another.

What i'd like is an option to only use the combat macro on Key Binding 1. That way, in combat with Tindral, or any future fight with this kind of gimmick, you still have access to whatever combat macro you use, but also can just use Key Binding 2 if you needed to mount.

Of course, I didn't even think of just putting the mount in the combat macro... The simplest solutions always escape me.

mbattersby commented 3 months ago

Oh yes, I see. That makes sense. I think it's a reasonable idea to separate the combat/unavailable macro by keybind. If it turns out that macros persist into TWW (very unlikely it seems) I'll look into it.

mbattersby commented 1 month ago

The good news is that it will be possible in TWW. The bad news is that I won't have time to look at it before then.