xodio / xod

XOD IDE
https://xod.io
GNU Affero General Public License v3.0
888 stars 119 forks source link

Fix: configure electron-settings for all kinds of processes #2087

Closed brusherru closed 3 years ago

brusherru commented 3 years ago

There is no issue 😬

What was wrong?

Updating of the electron also causes an update of the electron-settings package. The newer version of this package changed the default name of the settings file. To keep user settings we've changed the filename, but only in the main process. So it produced a bug when the user compile&upload something with third-party C++ libraries — the libraries from his workspace does not copy if he set a workspace in the custom (not default) path.

How it fixed?

On loading/saving settings we always set the path and file name for the settings file (for both kinds of processes).