XOD IDE loads libraries with invalid patch paths - Githubissues

xodio / xod

XOD IDE

https://xod.io

GNU Affero General Public License v3.0

888 stars 119 forks source link

XOD IDE loads libraries with invalid patch paths #2097

Closed brusherru closed 3 years ago

brusherru commented 3 years ago

Steps to reproduce

Open any project (with at least one patch)
Save the project in the YOUR_WORKSPACE/__lib__/somebody directory as a multifile project and name it with uppercase symbols. E.G. YOUR_WORKSPACE/__lib__/somebody/UpercaseSymbolsIsForbidden
Open any other project
Save it as a xodball
Try to open this xodball

Expected behavior

IDE opens a xodball.
There is no somebody/UppercaseSymbolsIsForbidden library in the project browser.
IDE shows an error message on the IDE start, which tells the user that some of the libraries have invalid names.

Actual behavior

IDE does not open a xodball, because it has INVALID_XODBALL_FORMAT
Xodball contains a patch(es) with path somebody/UppercaseSymbolsIsForbidden/patch-name
Project browser does not contain an invalid library

How to fix

Do not load libraries with an invalid username, project name, or patch names.
Show an error message on IDE start if such libraries have been found.