search

xoeye / gps-metadata-remover

Javascript package that removes GPS metadata from images and videos
Other
9 stars 3 forks source link

ffprobe should be a devDependency? #25

Closed dominik-dabrowski closed 2 years ago

dominik-dabrowski commented 2 years ago

If my reading of the source code is correct, ffprobe is only used for testing. If so, shouldn't it be in devDependencies? I implemented the change in https://github.com/substackinc/gps-metadata-remover/commit/18ea2bc24920c9b9561bfd481307260737697af5 :)

Aleclindner commented 2 years ago

Good catch, thanks :)

Aleclindner commented 2 years ago

Fixed in dev, I'll do a release