search

xofbd / wqu-weather-app

A demo web application for WorldQuant University Introduction to Data Science Module
GNU General Public License v3.0
7 stars 11 forks source link

Added Wiki Summary of the location #1

Closed gammaG2 closed 4 years ago

gammaG2 commented 4 years ago

Per the Proposed Future work, the location specific data summary is pulled from wikipedia and displayed as in here.

As more data is added, a shift to html templates might be considered, but since this is a demo app with limited scope, not implementing the same.

Thanks!

gammaG2 commented 4 years ago
  1. Yes you are absolutely correct! I am sorry this is my first PR and I need to come up to speed to the community guidelines and protocols for merging PRs.
  2. This needs a small update as I have not accounted for the local host deployment. as far as deployment mode is concerned, i am searching the wiki for city, country and posting the 1st summary, so I think that should handle all locations as thrown back by the weather API. The local host handling needs to be added nonetheless.
  3. Thanks, will read up on it nonetheless on general practices.
  4. I shall fix the commits. It seems to be in error.

Kindly Hold the merge request till the changes are implemented. Thanks!

xofbd commented 4 years ago

No worries, this project is meant for learning and practice. I personally like to use git add -u . to avoid adding new files to staging. As I said, I need to add a contributor guideline.