search

xogeny / XogenyTest

An example of a testing framework written in 100% Modelica
Other
15 stars 9 forks source link

Additional component for validating continuous trajectories #11

Closed AtiyahElsheikh closed 5 years ago

AtiyahElsheikh commented 5 years ago

Dear Michael,

Thank you for your awesome library. I was looking for something like that.

For my testing purposes I needed an additional component and thought to share it back.

Greetings Atiyah

AtiyahElsheikh commented 5 years ago

Additional component for validating continuous trajectories with own unit tests included

xogeny commented 5 years ago

Note my comment about the typo. Can you fix that?

AtiyahElsheikh commented 5 years ago

Where / How can I view your comment regarding the typo?

xogeny commented 5 years ago

Oops...I failed to submit my review. I submitted it now so you should have gotten my feedback about the typo. (I had not used GitHub code reviews before)

AtiyahElsheikh commented 5 years ago

Done!

https://github.com/xogeny/XogenyTest/pull/11/commits/c03b6de9426ccaa29e496d95dc7dba45b2b5d52e

AtiyahElsheikh commented 5 years ago

Just a small issue .. I changed the name of model via the online editor but the name of the file remained :)

I have already done the testing with OpenModelica (There are even OpenModelica specific annotation in the testing). I have also used the new component with the my new open-source GenKinetics library and so far it is working.