search

xogeny / XogenyTest

An example of a testing framework written in 100% Modelica
Other
15 stars 9 forks source link

Remove dependency on MSL #6

Closed xogeny closed 11 years ago

xogeny commented 11 years ago

There is one place where Time is used. But if we get rid of that (but keep the units?), then it is completely independent of the MSL. This is important because it means that then you could actually use it to test the MSL.

xogeny commented 11 years ago

This is made slightly more complicated now by the addition of Modelica.Constants.small as well as Modelica.SIunits.Time.

kdavies4 commented 11 years ago

Does the minor dependency on MSL necessarily mean it can't be used to test MSL? As long as those MSL classes can be verified manually (and it seems so), then it might be reasonable to include a disclaimer or list of assumptions in the documentation of XogenyTest. Or the Modelica.Constants.small and Modelica.SIunits.Time could be replaced by local copies. The condition in assertLogValue() could be replaced by (if actual >= expected then actual <= expected_10^o else expected <= actual_10^o), which handles the zero case without Modelica.Constants.small.

xogeny commented 11 years ago

Kevin, you are probably right, I think such a minor dependency is not likely to be an issue since I would not imagine changes to those sections of the MSL being likely.