search

xogroup / felicity

Javascript object constructors and sample data based on Joi schema.
Other
111 stars 9 forks source link

Update to Joi 14 #148

Closed WesTyler closed 5 years ago

WesTyler commented 5 years ago

Felicity needs to be updated to and tested against Joi 14.

WesTyler commented 5 years ago

In progress. Includes breaking changes in Joi around .example(), so this will be a semver major release for v4.

Going to try to get some bug fixes into 3.x before rebasing and PRing this, but the local commit is done.

mattkelly commented 5 years ago

@WesTyler do you happen to have an ETA for this? I'm interested in support for Joi 14.

WesTyler commented 5 years ago

Hey @mattkelly sorry, didn't realize anyone was watching and waiting on this :P

I'll double check 3.x tomorrow to make sure I've got that in good shape. If so I can get 4.0.0 to support Joi@14 published tomorrow afternoon.

WesTyler commented 5 years ago

Felicity@4.0.0 is published with support for Joi@14 :)

mattkelly commented 5 years ago

Thanks a ton for the fast turnaround on this, @WesTyler! I'll check it out. I really appreciate it.

WesTyler commented 5 years ago

Haha I don't know that I can claim fast turnaround when I opened the issue to do this about a month ago. Thank you for reminding me it was sitting here!