xogroup / tk-form-fields

3 stars 1 forks source link

Decouple from tk-bootstrap #15

Closed GeorgeTaveras1231 closed 7 years ago

GeorgeTaveras1231 commented 7 years ago

Blocked on #16, ~~#17~~

Goals

De-couple styles from tk-bootstrap

Concerns

Contributing to this project now requires access to our private npm registry.

Bugs

~~Label spacing is off by a pixel or two from working version~~

GeorgeTaveras1231 commented 7 years ago

Not sure why the build is failing. Everything is passing locally.

GeorgeTaveras1231 commented 7 years ago

Build is failing because of permission issues when trying to pull packages from gemfury

jazzcrazed commented 7 years ago

I would just add to the instructions to npm login for the XO Group Gemfury. Even though that dependency makes this far less useful to consume outside of XO, it's not revealing anything proprietary or vulnerable. Once that's set, I'm 👍

GeorgeTaveras1231 commented 7 years ago

Thanks for the feedback @jazzcrazed. I updated the documentation on #16

jazzcrazed commented 7 years ago

👍 🚢