Closed GeorgeTaveras1231 closed 7 years ago
Buttons lost their styling. I see you have a todo above for it, just wanted to call it out in case that is for something else.
@GeorgeTaveras1231: Do you get the below JS error on dev? Not sure if there is some other setup I need to do other than npm install
(index):1 Uncaught ReferenceError: XO is not defined
@GeorgeTaveras1231: Overall this looks great to me π I added a few comments above.
@pkelly I took some of your advice regarding naming and fixed the buttons. I also updated the documentation of the PR above. This has now become a lot more lengthy but I am happy to assist with the review process in whichever way I can. As far as the JS error you pointed out, this is because the server doesn't build the JS by default, that is something we should add. In the meantime just make sure to run npm run build
before viewing the demo page.
@GeorgeTaveras1231: Good call on the npm run build
Not sure how I missed that in the README π
I pulled the latest on this branch, but am getting an import error.
$ npm start
> @xogroup/tk-form-fields-pattern@3.0.0-0 start /Users/pkelly/work/tk-form-fields
> node index.js
TK Form Fields dev server listening on port 9494
source: /Users/pkelly/work/tk-form-fields/src/stylesheets/index.scss
dest: /Users/pkelly/work/tk-form-fields/public/index.css
read: /Users/pkelly/work/tk-form-fields/public/index.css
error: File to import not found or unreadable: @sharedweb/tk-typography/dist/latest/tk-typography
Parent style sheet: node_modules/@sharedweb/tk-buttons/dist/latest/tk-buttons.scss
in node_modules/@sharedweb/tk-buttons/dist/latest/tk-buttons.scss:3:1
Error: File to import not found or unreadable: @sharedweb/tk-typography/dist/latest/tk-typography
Parent style sheet: node_modules/@sharedweb/tk-buttons/dist/latest/tk-buttons.scss
at options.error (/Users/pkelly/work/tk-form-fields/node_modules/node-sass/lib/index.js:283:26)
Since this PR has gotten pretty huge I would suggest blocking any more major changes so that it can get merged in sooner than later.
@pkelly Thanks for looking at this again. That error is a result of the dependency issue I pointed out in that thing I wrote. I'm looking into it now.
@pkelly I ran the server locally and it worked fine.
@GeorgeTaveras1231 helped me out with that error. I had to clear my node_modules. Works great now π
Just an FYI this PR hasnt been merged because all of this code is likely to change once the distribution/package architecture of the union project is established
Changes
BEM style class declarations.
Introduce field container
From
fieldset
totk-field__group
Lightweight theme system
Export themed placeholders
// Use the default theme otherwise .my-form-is-in-white-background { @extend %tk-form-fields--default; }