search

xojs / eslint-config-xo-typescript

ESLint shareable config for TypeScript to be used with eslint-config-xo
MIT License
171 stars 25 forks source link

Should we include the Eslint rules override from @typescript-eslint/eslint-recommended ? #23

Open pvdlg opened 4 years ago

pvdlg commented 4 years ago

The @typescript-eslint/eslint-plugin provides a recommended config which turn off some Eslint rules that conflicts or doesn't work well with TypeScript.

For example in a types.d.ts file with the following code:

type MyType = {};

export {MyType};

the rules rule no-undef is incorrectly triggered.

I think this config is the right place to disable those rules. We could even just include plugin:@typescript-eslint/eslint-recommended here.

What do you think @sindresorhus ?

sindresorhus commented 4 years ago

I think this config is the right place to disable those rules. We could even just include plugin:@typescript-eslint/eslint-recommended here.

👍