xolox / python-coloredlogs

Colored terminal output for Python's logging module
https://coloredlogs.readthedocs.io
MIT License
545 stars 44 forks source link

AttributeError: module 'coloredlogs' has no attribute 'CAN_USE_BOLD_FONT' #82

Closed AbdulRahmanAlHamali closed 4 years ago

AbdulRahmanAlHamali commented 4 years ago

Hello, thank you for this beautiful package :)

In version 14.0 we are facing this error:

AttributeError: module 'coloredlogs' has no attribute 'CAN_USE_BOLD_FONT'

Was this removed or something?

roedoejet commented 4 years ago

Yes, looks like it was removed here: 044402534c2dd02ff340df2950e485ce4999386c was there a reason for the removal? This is a breaking change in our code.

xolox commented 4 years ago

Hi both, thanks for the feedback and sorry for the breaking change. A couple of thoughts on this:

About why CAN_USE_BOLD_FONT was removed:

AbdulRahmanAlHamali commented 4 years ago

Hi @xolox , thank you for your response. And yes, it makes sense since it is a major version change.

So to confirm that I understand correctly: CAN_USE_BOLD_FONT is not needed any more, because it will always be True?