Closed AbdulRahmanAlHamali closed 4 years ago
Yes, looks like it was removed here: 044402534c2dd02ff340df2950e485ce4999386c was there a reason for the removal? This is a breaking change in our code.
Hi both, thanks for the feedback and sorry for the breaking change. A couple of thoughts on this:
CAN_USE_BOLD_FONT
variable was never intended to be used outside of coloredlogs
.coloredlogs
were published, I picked up the habit of defining __all__
in the Python packages I publish, to avoid this ambiguity. Unfortunately it takes time to go back and retroactively add this to all my projects (I hadn't gotten to coloredlogs
yet).About why CAN_USE_BOLD_FONT
was removed:
colorama
was the only way to get colors on Windows.colorama
was basically dealing with a "leaky abstraction" (edge case) and like most developers I'd rather have less than more edge cases in my code, so with the advent of Windows 10 native ANSI support I decided to remove the special handling of colorama
.Hi @xolox , thank you for your response. And yes, it makes sense since it is a major version change.
So to confirm that I understand correctly: CAN_USE_BOLD_FONT
is not needed any more, because it will always be True
?
Hello, thank you for this beautiful package :)
In version 14.0 we are facing this error:
Was this removed or something?