search

xolox / vim-easytags

Automated tag file generation and syntax highlighting of tags in Vim
http://peterodding.com/code/vim/easytags/
1.01k stars 109 forks source link

In stage 2, don't touch the .viminfo file and don't create swap files. #54

Closed inkarkat closed 11 years ago

inkarkat commented 11 years ago

I've seen the tags update clobbering my ~/.viminfo history, especially because stage 2 doesn't run with my .vimrc settings and therefore with default sizes for the retained history. Also, turn off swap files; though stage 2 doesn't :edit any files, don't run the risk of accidentally littering the file system with swap files.

xolox commented 11 years ago

Indeed the child Vim process should be isolated from the user as much as possible. I had missed the command line option for the .viminfo file. Thanks for the pull request, it's merged!

inkarkat commented 11 years ago

Thanks for merging in my changes. Apart from the command escaping issue on Windows (#51, which I've worked around by hard-coding vim as the executable name), I've been successfully running the async branch productively; it's great, no more blocking! I'd say if you dropped the auto-detection of the Vim executable, and replace that with a config variable (effectively shifting the escaping mess to the user), it would be ready for prime time.

xolox commented 11 years ago

I'm glad to hear the async branch is working well for you. Coincidentally I was just working on #51, see my (long) reply there :-). One thing I'm wondering about though: Do you use Vim on Windows exclusively? Because I mostly work in Linux and Mac OS X and in Linux I've had Vim crash now and then while using the async branch. I actually switched back to the main branch because it got really annoying (despite having vim-session with periodic auto-save enabled).

xolox commented 11 years ago

While working on vim-easytags I checked out the async branch again, to give it another chance, and it crashed again within minutes. So this is a serious issue (on (my version of) Linux). All that's left to do is run Vim under GDB.

inkarkat commented 11 years ago

You're right, I almost exclusively (have to) work on Windows 7 64-bit, with a custom Vim 7.3.823 build right now. Never had any crashes related to easytags. I do have some Linux systems / VMs, but I rarely do extensive edits there. With your feedback, maybe I get to exercise that OS more in the next days. I'll keep you updated!

xolox commented 11 years ago

Thanks for merging in my changes. Apart from the command escaping issue on Windows (#51, which I've worked around by hard-coding vim as the executable name), I've been successfully running the async branch productively; it's great, no more blocking!

FYI: The result of xolox#misc#os#find_vim() can now be configured without having to patch vim-misc (I guess my logic will never be 100% right so more users may need this in the future, this is why I decided to make it configurable).