search

xolox / vim-easytags

Automated tag file generation and syntax highlighting of tags in Vim
http://peterodding.com/code/vim/easytags/
1.01k stars 109 forks source link

Add g:easytags_suppress_report option #95

Closed blukat29 closed 10 years ago

blukat29 commented 10 years ago

Currently, easytags reports the tag file update status. This feature is disabled by default on async mode, but is enabled on sync mode. The problem is that this message overwrites other vim messages. As a result, if I save a file and switch into insert mode, I cannot see --INSERT-- string.

g:easytags_suppress_report works pretty much similar to g:easytags_suppress_ctags_warning option. If this variable is set and true, easytags does not print the update status.

xolox commented 10 years ago

Hi Yunjong,

Thanks for the pull request! It's now merged. I did change the implementation during merging because:

  1. I wanted to have the logic for easytags_suppress_report to be in one place (inside report_results()).
  2. You accidentally disabled the synchronous updates (unless I'm mistaken) because you moved the call to xolox#easytags#update#with_vim() inside the if statement. With my change xolox#easytags#update#with_vim() is always called and the silencing of the message happens inside report_results().
blukat29 commented 10 years ago

Oh, that looks nice! Thanks for the feedback.