search

xolox / vim-lua-ftplugin

Lua file type plug-in for the Vim text editor
http://peterodding.com/code/vim/lua-ftplugin
187 stars 27 forks source link

Update to Lua 5.2 keywords and standard libraries #30

Closed stormc closed 9 years ago

stormc commented 9 years ago

If you merge this and consider to also merge 2c69923, autoload/xolox/lua.vim line 403 should include 'bit32' in the returned modules list.

Sorry for the "pull request & merge hell", I should have planned it a bit more carefully.

xolox commented 9 years ago

Hi Christian,

Thanks for the pull request! This is now merged and released as version 0.8. I added bit32 to the new 'white list' you added in the other pull request.

About careful planning: Hundreds of users just create GitHub issues and get upset when I don't respond quickly enough (there are literally hundreds of issues, I can't keep up in my spare time). Then there are those who "put their money where their mouth is" by creating a pull request. Even then I frequently need some back and forth to get a pull request in a state where I can merge it. In this case I looked through the changes, thought "I would have done it like that" and merged both pull requests. So guess which type of feedback I prefer? ;-)

Happy Vimming!