search

xolox / vim-notes

Easy note taking in Vim
http://peterodding.com/code/vim/notes/
1.6k stars 110 forks source link

Made concealing configurable #104

Closed naddeoa closed 9 years ago

xolox commented 9 years ago

Hi Anthony and thanks for the contribution! I've merged your pull request but had to make a few changes while merging:

  1. I changed the logic inside syntax/notes.vim to use the function xolox#misc#option#get() with a default option value of true (1). In my mind this makes a lot more sense than checking for the existence of variables without checking their actual values.
  2. I renamed notes_conceal_italics to notes_conceal_italic to be consistent with the other options (IMHO).
  3. I rewrote the documentation additions because A) doc/notes.txt is generated from README.md so your changes would have gone lost and B) because there were typos in the additions (s/coneal/conceal/g).
  4. The documentation for notes_conceal_code was incorrect because your code changes only apply to the markers for inline code fragments, not the markers for multi line code blocks (I'm guessing you changed your mind about the implementation at some point?). I kept the implementation as is and updated the documentation to match the implementation.

Happy Vimming!

naddeoa commented 9 years ago

Thanks a lot, and good catches, I need to be more careful before issuing pull requests.