search

xolphin / xolphin-api-php

Xolphin API module for PHP
8 stars 16 forks source link

Package not yet fully updated for the upcoming changes? #36

Closed dvdheiden closed 11 months ago

dvdheiden commented 11 months ago

Hi!

We've received the message about the upcoming changes and I wanted to implemented those changes asap. But I have the idea that this package hasn't been fully updated yet.

According to the document with the upcoming changes:

4.1.1 REST [POST] /requests REST [POST] /certificates/{id}/reissue REST [POST] /certificates/{id}/renew The parameter “approverRepresentativeEmail” must be provided on all OV/EV orders from January 15, 2024 within the Xolphin API, for all OV/EV SSL, code signing, and PDF signing requests. Please update these variables as soon as possible.

I do see that the CertificateRequest class has been updated, but the RenewRequest class and the ReissueRequest class seem not to be updated as those are still missing the approverRepresentativeEmail.

So I was wondering if I'm not fully understanding the changes or this package still needs an additional update to be prepared for the upcoming changes.

ohalessl247 commented 11 months ago

Hello, Good spot, those endpoints shall be updated by the end of today.

dvdheiden commented 11 months ago

Wow, that's quick! Thank you and I'm looking forward to the new version!