search

xolphin / xolphin-api-php

Xolphin API module for PHP
8 stars 16 forks source link

Outdated documentation #42

Closed rudybroersma closed 3 months ago

rudybroersma commented 3 months ago

The README.md could use some love. It seems outdated?

https://github.com/xolphin/xolphin-api-php/blob/master/readme.md#renew-certificate

These lines don't work:

$renew = new \Xolphin\Requests\RenewRequest($currentCertificate->product, <years>, '<csr_string>', DCVTypes::FILE_VALIDATION);
$renew->setApproverEmail('email@domain.com');

The first parameter of RenewRequest requires an integer, while $currentCertificate->product returns a Product object. It should be: $renew = new \Xolphin\Requests\RenewRequest($currentCertificate->product->id, <years>, '<csr_string>',

Then we're left with: PHP Deprecated: Method Xolphin\Requests\RenewRequest::setApproverEmail is deprecated use setApproverRepresentativeEmail or addDcv in vendor/xolphin/xolphin-api-php/src/Requests/RenewRequest.php on line 321