xolstice / protobuf-maven-plugin

Maven Plugin that executes the Protocol Buffers (protoc) compiler
https://www.xolstice.org/protobuf-maven-plugin/
Other
232 stars 76 forks source link

Extract generation of descriptor set into separate goals #54

Closed sergei-ivanov closed 5 years ago

sergei-ivanov commented 5 years ago

Is your feature request related to a problem? Please describe.

Generation of descriptor sets was an early feature, implemented before the introduction of language-specific goals. It requires a number of additional parameters that pollute the API and often functionally duplicate the existing parameters.

Describe the solution you'd like

Create two new goals compile-descriptor-set and test-compile-descriptor-set. Move all functionality related to descriptor set generation there. Reuse common parameters, such as outputDirectory.

Describe alternatives you've considered

This will be a breaking change, but it will only affect a very small number of users. Considering that the next release will contain a whole range of potentially breaking changes, now it looks like a good time to implement them all at once.