xolvio / meteor-rtd-example-project

A template project to use for creating a meteor app with unit and webdriver testing
91 stars 27 forks source link

Coverage is not generated #41

Closed Maxim-Filimonov closed 10 years ago

Maxim-Filimonov commented 10 years ago

So I tried to run RTD on this project according to README and seems to not working. First, there is a problem with jasmine-node -> https://github.com/mhevery/jasmine-node/issues/330 Which I've managed to fix by putting jasmine-reports: "^1.0.0 in package.json. But even after that I can't make it work. All test pass but looks like coverage is not generated

./node_modules/.bin/rtd runOnce --debug
....
Running "postLatestUnitCoverage" task
[D] Task source: /Users/maxim/repos/meteor_learning/meteor-rtd-example-project/node_modules/rtd/Gruntfile.js
No coverage reports available from unit tests

See full log Any ideas?

alanning commented 10 years ago

Not sure why coverage reports are not working but I wanted to let you know about the velocity project which is a successor to RTD. We don't have coverage reports yet but plan to include those.

@samhatoum can way in with the official word but my impression is that RTD is being sun-setted in favor of velocity.

samhatoum commented 10 years ago

Yes, all hands on deck are on velocity at the moment, I've yet to make that official as I want to fully support everything that RTD does currently to make the transition for existing RTD smooth.

As for the question itself, do you have coverage report files being generated under the PROJECT_BASE_PATH + '/build/reports/coverage' directory?

Maxim-Filimonov commented 10 years ago

Ah right I'll start looking at velocity then. @samhatoum nope they are not generated.

tree build
build
├── mirror_app
│   ├── client
│   │   ├── leaderboard.html
│   │   └── leaderboard.js
│   ├── css
│   │   └── leaderboard.css
│   ├── models
│   │   └── Players.js
│   ├── packages
│   │   ├── istanbul-middleware-port -> /Users/maxim/repos/meteor_learning/meteor-rtd-example-project/node_modules/rtd/lib/istanbul-middleware-port
│   │   └── meteor-fixture -> /Users/maxim/repos/meteor_learning/meteor-rtd-example-project/node_modules/rtd/lib/meteor-fixture
│   ├── public
│   │   ├── favicon.ico
│   │   └── robots.txt
│   └── server
│       ├── fixture.js
│       └── leaderboard.js
└── reports
    ├── TEST-Leaderboardfunctionality.xml
    └── TEST-UnitTests.xml

10 directories, 10 files
samhatoum commented 10 years ago

How odd. Did you add a custom karma.conf.js? It's actually karma that does the unit-test instrumentation

Maxim-Filimonov commented 10 years ago

Nope haven't touched anything. Just cloned the repo and added jasmine_reporters: "^1.0.0" to package.json BTW just found out that jasmine-node problem affects velocity examples too :(

alanning commented 10 years ago

@Maxim-Filimonov That jasmine-node / reporters problem should be fixed in the velocity examples since we updated jasmine-unit. If its still causing errors, please report that on the jasmine-unit issues tracker.

In particular we tracked those issues in these closed tickers here:

https://github.com/xolvio/jasmine-unit/issues/19 https://github.com/xolvio/jasmine-unit/issues/21

If you are still seeing one of those issues, please re-open the appropriate ticket.

samhatoum commented 10 years ago

I'll try to checkout the project later and see if I can repeat it. Thanks for reporting :+1:

Maxim-Filimonov commented 10 years ago

@samhatoum @alanning thanks for your helping with figuring this out. After applying https://github.com/xolvio/rtd/pull/169 manually I've managed to make example working again with fresh git clone :+1: Closing this one, than :)