app_install password is visible in command history

xomachine / SteamForwarder

steam_api.dll implementation for wine. Your windows games now can interact with your linux steam! (This repo mirrors https://gitlab.com/xomachine/SteamForwarder)

MIT License

198 stars 8 forks source link

app_install password is visible in command history #12

Closed bmwalters closed 6 years ago

bmwalters commented 6 years ago

Because the password is passed in via a command line argument, it is recorded in the user's shell history. Most applications ask for a password separately using something like getpass. It also gives the user peace-of-mind because the password isn't cleary visible in the terminal.

xomachine commented 6 years ago

Indeed, the password should not be stored in the shell history. Thanks for the tip-off. Fixed by d368eda32863e6f706d81a5e771ec31109186c5a