search

xomaczar / ember-cli-ion-rangeslider

An Ember and ion.RangeSlider integration, packaged as an Ember-cli addon.
MIT License
7 stars 14 forks source link

Doesn't work with prototype extensions off #10

Open vlascik opened 7 years ago

vlascik commented 7 years ago

If you have Ember function prototype extensions turned off (I think it's discouraged a lot now), .on is not a function and this addon fails:

"TypeError: (intermediate value)(intermediate value).on is not a function
    at Module.callback (http://localhost:4200/assets/vendor.js:218684:8)
    at Module.exports (http://localhost:4200/assets/vendor.js:132:32)
....

This should be rewritten in mixin: (_startObserving, _stopObserving) and in addon (didInsertElement and willDestroyElement).

https://guides.emberjs.com/v2.3.0/configuring-ember/disabling-prototype-extensions/

NLincoln commented 7 years ago

Hi @vlascik, it looks like this addon is no longer maintained. You should go check out my fork over at #9 . I've made several fixes over there that I think you should check out! If you have any questions feel free to raise an issue.