search

xomaczar / ember-cli-ion-rangeslider

An Ember and ion.RangeSlider integration, packaged as an Ember-cli addon.
MIT License
7 stars 14 forks source link

disabled attribute not working #7

Open trampos opened 8 years ago

trampos commented 8 years ago

The attribute disabled is not working, i managed to make it work changing it to disable, like on the ion-range-slider docs.

xomaczar commented 8 years ago

do you want to make a PR

trampos commented 8 years ago

Actually I have never did a pull request, should I write any type of test or just pull my change?

trampos commented 8 years ago

i made it

xomaczar commented 8 years ago

This is was the first addon I published, so I did not spend any time on tests. I would love to have the tests; tldr I need to bring this addon to the latest ember and add tests. Let me work on that then you can rebase your code against the master and add tests.

xomaczar commented 8 years ago

i am thinking about changing the name to just ember-ion-rangeslider, cli makes little sense now.