search

xombra / firefox-showip

Automatically exported from code.google.com/p/firefox-showip
0 stars 0 forks source link

New button style enlarges the ENTIRE status bar. #51

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
What steps will reproduce the problem?
1. Load the Plugin
2. Put it in your Status bar
3. Look at your status bar

What is the expected output? What do you see instead?
Before the last update my status bar was fairly small (minimal) and the height 
of it was the height of the tallest text, enough room for all my plugins. Now, 
after the latest update, the huge styling of the button has caused my status 
bar to grow at least 25% in size. I would like the option to disable the fancy 
styling of the button and go back to just text since it provides no additional 
functions and just makes my status bar bulky.

What version of the product are you using? On what operating system?
Windows 7 (although I think Mac is also affected)

Please provide any additional information below.
May revert back to the previous version due to this.

Original issue reported on code.google.com by briandic...@gmail.com on 2 Jun 2011 at 3:02

GoogleCodeExporter commented 9 years ago 
I can confirm that MacOS is also affected. Overly tall status bar. Firefox 4 
with Status-4-Evar plugin.

Original comment by unixtip...@gmail.com on 2 Jun 2011 at 7:46

GoogleCodeExporter commented 9 years ago 
I liked old style more. The current one enlarges addon bar and looks like a 
big, misplaced button.

Original comment by patryk.s...@gmail.com on 2 Jun 2011 at 8:26

GoogleCodeExporter commented 9 years ago 
Yeah, sorry about that. Working on a fix. ETA ~24h

Original comment by jan.ditt...@gmail.com on 2 Jun 2011 at 8:27

GoogleCodeExporter commented 9 years ago 
Please try http://firefox-showip.googlecode.com/files/showip_1.1rc1.xpi

Original comment by jan.ditt...@gmail.com on 3 Jun 2011 at 6:28

GoogleCodeExporter commented 9 years ago 
It's better with 1.1rc1, but it still enlarges the status bar by ~50%.

Original comment by stefan.s...@gmail.com on 3 Jun 2011 at 4:13

GoogleCodeExporter commented 9 years ago 
Can you send me a screenshot?

Original comment by jan.ditt...@gmail.com on 3 Jun 2011 at 4:46

GoogleCodeExporter commented 9 years ago 
MacOS, Firefox 4, Status-4-Evar. While i do think that a smaller status bar 
would generally be desirable, I can't confirm comment #5. Status bar height is 
identical with or without ShowIP enabled. Thanks for the fix.

Original comment by unixtip...@gmail.com on 3 Jun 2011 at 5:19

GoogleCodeExporter commented 9 years ago 
Here is a screencast of the additional height 1.1rc1 adds:
http://screencast.com/t/jW7mnQtSB5

Definitely an improvement, but still noticeable.

Original comment by briandic...@gmail.com on 3 Jun 2011 at 6:14

GoogleCodeExporter commented 9 years ago 
the text used to be normal size now the height of my toolbar is 3x the original 
height:( reverting to showip_1p0r94b0367.xpi fixes the size problem.
debian sid/ff 4.0.1

Original comment by obero...@gmx.net on 3 Jun 2011 at 8:30

GoogleCodeExporter commented 9 years ago 
http://postimage.org/image/1yd2svr2c/
with 1..1rc.1 i gets indeed a bit smaller:)

please excuse the double post ...

Original comment by obero...@gmx.net on 3 Jun 2011 at 8:44

GoogleCodeExporter commented 9 years ago 
Here a screenshot from 1.1rc1 (FF 4.0.1, Windows 7).
The Firebug icon in the status bar is just to see the size difference; the 
effect of enlarging also occurs if ShowIP is the only AddOn attached to the 
status bar.

Original comment by stefan.s...@gmail.com on 4 Jun 2011 at 5:54

Attachments:

GoogleCodeExporter commented 9 years ago 
so 1.1rc2 should fix that: 
http://firefox-showip.googlecode.com/files/showip_1.1rc2.xpi

Original comment by jan.ditt...@gmail.com on 4 Jun 2011 at 6:58

GoogleCodeExporter commented 9 years ago 
Yes, it's fixed with 1.1rc2 (in fact, it's still 3-4 pixels higher that without 
the ShowIP button, but the difference is so small now that it's no longer an 
issue IMHO). Thanks for the quick fix! Great job! *thumbsup*

Original comment by stefan.s...@gmail.com on 4 Jun 2011 at 8:11

GoogleCodeExporter commented 9 years ago 
Yes, it's a lot better, still few pixels to cut down, but it's good enough to 
release it. I'd like to see them cut down anyway. Every pixel on my laptop 
counts... ;(

Original comment by patryk.s...@gmail.com on 4 Jun 2011 at 8:16

GoogleCodeExporter commented 9 years ago 
Is the font size bigger than with other statusbar items? Or is there still a 
border around the text?

Original comment by jan.ditt...@gmail.com on 4 Jun 2011 at 5:22

GoogleCodeExporter commented 9 years ago 
thanks for the fix:) my impression is that the font size is the same that other 
plugins use.
http://postimage.org/image/kczrmt9g/ - 1.1rc3

Original comment by obero...@gmx.net on 5 Jun 2011 at 11:23

GoogleCodeExporter commented 9 years ago 
RC3 works perfectly. It doesn't enlarge addon bar at all on Mac. Great job!

Original comment by patryk.s...@gmail.com on 6 Jun 2011 at 11:37

GoogleCodeExporter commented 9 years ago 
Any chance to release to addons.mozilla.org soon?

Original comment by patryk.s...@gmail.com on 8 Jun 2011 at 9:17

GoogleCodeExporter commented 9 years ago 
I'm happy with RC3, the font-size is smaller than it used to be but I can live 
with it and it doesn't enlarge the add-on bar in Windows either.

Original comment by briandic...@gmail.com on 8 Jun 2011 at 9:21

GoogleCodeExporter commented 9 years ago 
For the release I still need to triage the bug reports of people who don't have 
the plugin showing at all w/ 1.1rc3. I may have to revert a change which only 
adds the plugin _once_ to the addonbar and not on every startup.

Original comment by jan.ditt...@gmail.com on 11 Jun 2011 at 10:09

GoogleCodeExporter commented 9 years ago 
Any release soon? :) If you still want to track down adding to addonbar, then 
maybe one bug at a time ;)

Original comment by patryk.s...@gmail.com on 22 Jun 2011 at 10:12