xonsh / xontrib-jedi

Xonsh Python mode completions using jedi
MIT License
19 stars 2 forks source link

fix: Import submodule for overwritting completion method #4

Closed TeddyHuang-00 closed 6 months ago

TeddyHuang-00 commented 9 months ago

Hi! Thank you for the awesome xontrib! I gave it a star!

Please take a look at my PR that address the issue mentioned in https://github.com/xonsh/xontrib-jedi/issues/3

For community

⬇️ Please click the 👍 reaction instead of leaving a +1 or 👍 comment

eode commented 9 months ago

This fixes the issue for me.

LoicGrobol commented 6 months ago

ping @jnoortheen @anki-code, can we expect this to be merged? Or is there anything the community can do to help?

jnoortheen commented 6 months ago

There are some failing checks. But it looks good to be merged. Thanks @TeddyHuang-00 !