search

xonsh / xontrib-template

Full-featured template for building extension (xontrib) for the xonsh shell.
MIT License
42 stars 12 forks source link

Including requirements.txt #24

Closed jnoortheen closed 1 year ago

jnoortheen commented 1 year ago

@anki-code does this template need requirements.txt ? we use PEP-621 meta data or poetry. https://github.com/xonsh/xontrib-template/blob/5f8cd1ee9bc05a3cab7ed439725a5b8ae1d1e690/project-template/%7B%7B%20project_repo_name%20%7D%7D/requirements.txt#L1

anki-code commented 1 year ago

I include requirements.txt to give Github information about dependencies. But now I see Github removed the dependencies visualisation and requirements.txt is not needed. I've deleted it.

anki-code commented 1 year ago

@jnoortheen I see reuirements is needed to testing action - https://github.com/xonsh/xontrib-abbrevs/actions/runs/4191606414/jobs/7266207087

Run actions/setup-python@v3
Warning: The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Successfully setup CPython (3.8.16)

Error: No file in /home/runner/work/xontrib-abbrevs/xontrib-abbrevs matched to [**/requirements.txt], make sure you have checked out the target repository
jnoortheen commented 1 year ago

The actions needs to be updated like this https://github.com/xonsh/xontrib-distributed/blob/main/.github/workflows/test.yml#L12 . The code in the template might be outdated.