Closed Osc100 closed 1 year ago
This isn't ready to merge because it doesn't work out of the box on Fedora as described here.
https://github.com/xoocoon/hp-15-ew0xxx-snd-fix/issues/12#issuecomment-1690499918
Any help would be appreciated.
The kernel-module_patch.sh change should be implemented though, since there are more people with the same issue #11. (Had to change the reference to the new filename)
Oh my god you're a life saver! I got this version working on my HP ENVY x360 2-in-1 Laptop 15-fe0xxx.
I first had to remove the extraneous chmod
for dkms-patchmodule.sh
at the bottom of dkms-module_create.sh
. Then, I added this patch line to setup_snd-hda-codec-realtek.sh
+ SND_PCI_QUIRK(0x103c, 0x8bdf, "HP Envy x360 2-in-1 Laptop 15-fe0xxx", ALC287_FIXUP_CS35L41_I2C_2),
It worked like a charm! I will note I had an error during the script in which dracut
couldn't find a folder in /boot/efi
, but it worked regardless.
I didn't have any dependency issues, but I did already do some tinkering with the original script without this PR to try to get it working on Fedora myself, so I may have installed some dependencies while doing that that aren't included in this PR.
It seems that you used the previous version (Fedora only) that was in the main branch, that's why you had to delete that line, my fault since that was the default branch on my repo, I just changed it, thank you for helping me notice.
I'm glad it helped you! :D
I don't know if it'd be the same as running it at bare metal, but I'll fire a virtual machine later today to test if at least the script works on a fresh installation since the audio fix seems to work with no problems.
Yess, the installation worked on a fresh Fedora installation (on a VM), so the dependencies are working (had to upgrade the kenel and reboot though).
So I'd say everything is working at least on my tests.
Also changed the readme.md to reflect those changes.
The dkms-patchmodule.sh file referenced on line 72 and 80 here isn't created anymore, instead replaced for the kernel-module_patch.sh.:
https://github.com/xoocoon/hp-15-ew0xxx-snd-fix/blob/e9b5a12b993625bec9094994669ac92dc82ff06a/dkms-module_create.sh#L72-L80
The script probably worked despite this because of the leftover files produced with the old versions, so this PR fixes that.
Also added the distro specific commands for Fedora in the same way that they were implemented for arch. It would be great if someone tested this on Fedora with a fresh installation, since I don't know if I'm missing one or two dependencies.