Closed xoofx closed 4 months ago
@MihaZupan I added you as a reviewer. First time in years that I haven't implemented an extension to markdig 😅
Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | ||
---|---|---|---|---|---|
src/Markdig/Extensions/Alerts/AlertBlockRenderer.cs | 37 | 38 | 97.37% | ||
src/Markdig/MarkdownExtensions.cs | 5 | 7 | 71.43% | ||
src/Markdig/Extensions/Alerts/AlertInlineParser.cs | 60 | 77 | 77.92% | ||
<!-- | Total: | 136 | 156 | 87.18% | --> |
Totals | |
---|---|
Change from base Build 8092414745: | -0.07% |
Covered Lines: | 26086 |
Relevant Lines: | 27363 |
Hi Alexandre,
I was trying your code and I found a situation where the AlertBlock
might not be parsed.
For this example, I added a code block inside the alert:
> [!NOTE]
> Highlights information that users should take into account, even when skimming.
> Testing rendering for multiple lines
> ```csharp
> var test = "I can also add code to panels
> ```
> `Inline code testing`
This is the result on GitHub markdown:
[!NOTE] Highlights information that users should take into account, even when skimming. Testing rendering for multiple lines
var test = "I can also add code to panels
Inline code testing
Although, it will never be rendered, since is not parsed as an AlertBlock
.
The same goes to if I want to add a nested quote block on the alert:
> [!NOTE]
> Highlights information that users should take into account, even when skimming.
> > Nested quoteblock
> > more info
> > other
Expected result:
[!NOTE] Highlights information that users should take into account, even when skimming.
Nested quoteblock more info other
If you need more info regarding this, I'm available to help.
I was trying your code and I found a situation where the AlertBlock might not be parsed.
Thanks, good catch, I have a fix. I mistakenly forgot that inline parser happens after all blocks have been parsed.
Thanks all for the review!
Hi @xoofx
I was trying the new version and it seems that the paragraphs within the AlertBlock
are not being rendered.
Markdown example:
> [!NOTE]
> Highlights information that users should take into account, even when skimming.
>
> Testing rendering for multiple lines
>
> `Inline code testing`
>
> Other line
>
> > Nested quote
> >
> > Final nested quote line
>
> Final line of alert
Expected:
[!NOTE] Highlights information that users should take into account, even when skimming.
Testing rendering for multiple lines
Inline code testing
Other line
Nested quote
Final nested quote line
Final line of alert
HTML rendered result:
<div class="markdown-alert markdown-alert-note">
<p class="markdown-alert-title"><svg viewBox="0 0 16 16" version="1.1" width="16" height="16" aria-hidden="true"><path d="M0 8a8 8 0 1 1 16 0A8 8 0 0 1 0 8Zm8-6.5a6.5 6.5 0 1 0 0 13 6.5 6.5 0 0 0 0-13ZM6.5 7.75A.75.75 0 0 1 7.25 7h1a.75.75 0 0 1 .75.75v2.75h.25a.75.75 0 0 1 0 1.5h-2a.75.75 0 0 1 0-1.5h.25v-2h-.25a.75.75 0 0 1-.75-.75ZM8 6a1 1 0 1 1 0-2 1 1 0 0 1 0 2Z"></path></svg>Note</p>
<p>Highlights information that users should take into account, even when skimming.</p>
<p></p>
<p></p>
<p></p>
<blockquote>
<p></p>
<p></p>
</blockquote>
<p></p>
</div>
Do you want me to open an issue with this info?
Do you want me to open an issue with this info?
Yes please.
Fixes #774
This extension does not support roundtrip.