search

xoofx / zio

A cross-platform abstract/virtual filesystem framework with many built-ins filesystems for .NET
BSD 2-Clause "Simplified" License
817 stars 61 forks source link

AggregateFileSystem can list duplicate entries #27

Closed Rohansi closed 6 years ago

Rohansi commented 6 years ago

If more than one filesystem has the same entry at a path the aggregate will list both. I don't consider this desirable because there would be no way to access the duplicate entries except through the original filesystem. Although it's possible and I'm sure someone will have a strange use for it this behavior is inconsistent with how normal file operations work on it.

The filesystem watcher is probably affected as well because it would need to check if a filesystem with higher priority also contains an entry for the path referenced by the event.

xoofx commented 6 years ago

If more than one filesystem has the same entry at a path the aggregate will list both.

Really? Then that's a bug... I thought I covered originally this case... The code supposed to do this is there, maybe there is an obvious oversight:

https://github.com/xoofx/zio/blob/d087166165531cf93884a8c8d63e6587efd7e9b3/src/Zio/FileSystems/AggregateFileSystem.cs#L359-L374

Rohansi commented 6 years ago

Sorry, it looks like this was just an issue on my end.