xoofx / zio

A cross-platform abstract/virtual filesystem framework with many built-ins filesystems for .NET
BSD 2-Clause "Simplified" License
806 stars 61 forks source link

Drive letter casing #48

Closed Ellested closed 4 years ago

Ellested commented 4 years ago

Hi,

First of all, this library is really nice, and well written - very good job :-)

There's a small glitch in that you can actually mount windows file systems with uppercase drive letters and it seems to work fine, until you try and enumerate the directories.

Maybe, it can be more forgiving by aligning the drive letter casing somewhere?

image

xoofx commented 4 years ago

Indeed, PR welcome for a fix.

xoofx commented 4 years ago

Actually I should provide a fix as I have another commit to add and a new version to release.

xoofx commented 4 years ago

There's a small glitch in that you can actually mount windows file systems with uppercase drive letters and it seems to work fine, until you try and enumerate the directories.

Maybe, it can be more forgiving by aligning the drive letter casing somewhere?

So I will throw an exception probably at creation time instead to match the behavior on Linux (it would be confusing that the same program works on windows but not on WSL for instance)

xoofx commented 4 years ago

Should be fixed in 0.8.0