search

xoofx / zio

A cross-platform abstract/virtual filesystem framework with many built-ins filesystems for .NET
BSD 2-Clause "Simplified" License
827 stars 61 forks source link

Strong-named assembly #63

Open lahma opened 2 years ago

lahma commented 2 years ago

Currently this library cannot be consumed from strong-named assembly. Would you accept a PR to add new generated snk file and directives to sign the assembly?

xoofx commented 2 years ago

Yes, as much as I hate SN 😅, it will require a separate NuGet (Zio.Signed). I'm usually handling it with a separate project only used in the CI (and not referenced by the sln). See Scriban.Signed for inspirations (it requires to extract props from the Zio project to import then in Zio.Signed)

lahma commented 2 years ago

I think the general advice from MS is just sign and give the key to public, is there a particular reason you don't want assembly be signed by default?

xoofx commented 2 years ago

I think the general advice from MS is just sign and give the key to public, is there a particular reason you don't want assembly be signed by default?

I have never had a need for them and they always caused more trouble to handle simple things (e.g drop a new version of the DLL in a folder can't be done without writing binding redirects)

lahma commented 2 years ago

OK, fair enough, thanks for clarifying.