search

xoofx / zio

A cross-platform abstract/virtual filesystem framework with many built-ins filesystems for .NET
BSD 2-Clause "Simplified" License
827 stars 61 forks source link

An AggregateFileSystem in an AggregateFileSystem stomps in TryGetPath #64

Closed garrynewman closed 2 years ago

garrynewman commented 2 years ago

In TryGetPath we just return here

https://github.com/xoofx/zio/blob/2aa6085e84a3b9ad0e7b37f936976e9cc47f8fcb/src/Zio/FileSystems/AggregateFileSystem.cs#L556-L559

But we should really only be returning if the path it returns is valid, since it isn't giving the other systems a chance to check for the file.

xoofx commented 2 years ago

Yep, agreed

xoofx commented 2 years ago

Fixed by commit 8a42485