search

xoofx / zio

A cross-platform abstract/virtual filesystem framework with many built-ins filesystems for .NET
BSD 2-Clause "Simplified" License
806 stars 61 forks source link

Correction GetFirstDirectory #72

Closed ykafia closed 1 year ago

ykafia commented 1 year ago

GetFirstDirectory should work with relative paths too and not remove omit the first character

xoofx commented 1 year ago

Thanks! Sorry, completely forgot about this PR.

Could you add some tests please?

ykafia commented 1 year ago

I've added some on a separate file as it's not internal to the UPath behavior, let me know if that's okay

xoofx commented 1 year ago

@ykafia many tests are failing in UPath likely due to the changes

ykafia commented 1 year ago

I will look into it

ykafia commented 1 year ago

All tests are passing now!

coveralls commented 1 year ago

Coverage Status

Coverage: 90.624% (+0.009%) from 90.614% when pulling 80998d64ba24e2182f3d5ceeabfae30c5b165243 on ykafia:ykafia-patch-extension into 930974d2bb5aab4d313b2c5989fe23d0638faa12 on xoofx:main.

xoofx commented 1 year ago

Thanks!