Closed bollhals closed 1 year ago
Thanks, I'm ok with the changes. Looks like some tests are failing, if you could have a look.
I removed the explicit null assert, as if it is null, it can never be absolute. This is the cause of the failing tests, let me know if I should adjust the tests to ArgumentException instead of ArgumentNullException, or whether to put this back.
From here: https://github.com/xoofx/zio/pull/77#discussion_r1348451555
Can you let me know what you prefer?
Reminder: Which way shall I adjust it to fix the tests?
I'm on a business trip and pretty busy, will come back hopefully next week, my apologies.
The CI is failing because dotnet-releaser
is requiring net7.0
, so I bumped it on main, you can merge main back.
I had to make further change to main (drop some old targets, but that's ok)
rebased and solved the failing tests, should be ready.
Thanks for the contribution, my apologies that it took some time and ping/pong to review it. 🙂
In my project, we're using your great library.
Lately we've been analyzing our performance, and your library came up a few times. This collection of fixes were mostly some low hanging fruits to improve things here and there a bit. I'll comment on them for better understanding.
There are a few other places that I can improve on, but that's for later if wanted.