search

xoofx / zio

A cross-platform abstract/virtual filesystem framework with many built-ins filesystems for .NET
BSD 2-Clause "Simplified" License
827 stars 61 forks source link

Fix and enable tests in CI for Linux #86

Closed GerardSmit closed 5 months ago

GerardSmit commented 5 months ago

While working on #85, I've ran the tests on Linux to validate my changes work on both Windows and Linux, however on Linux the tests are failing:

Failed!  - Failed:    13, Passed:   415, Skipped:     0, Total:   428, Duration: 2 s - Zio.Tests.dll (net8.0)

The following tests are failing:

[xUnit.net 00:00:00.44]     Zio.Tests.FileSystems.TestPhysicalFileSystemCompat.TestDirectoryDeleteAndOpenFile [FAIL]
[xUnit.net 00:00:00.57]     Zio.Tests.FileSystems.TestPhysicalFileSystem.TestFile [FAIL]
[xUnit.net 00:00:00.70]     Zio.Tests.FileSystems.TestZipArchiveFileSystem.TestCommonRead [FAIL]
[xUnit.net 00:00:00.71]     Zio.Tests.FileSystems.TestPhysicalFileSystem.TestDirectory [FAIL]
[xUnit.net 00:00:00.83]     Zio.Tests.FileSystems.TestSubFileSystem.TestBasic [FAIL]
[xUnit.net 00:00:00.91]     Zio.Tests.FileSystems.TestPhysicalFileSystem.TestFileExceptions [FAIL]
[xUnit.net 00:00:01.10]     Zio.Tests.FileSystems.TestPhysicalFileSystem.TestCommonRead [FAIL]
[xUnit.net 00:00:01.35]     Zio.Tests.FileSystems.TestPhysicalFileSystem.TestDirectoryExceptions [FAIL]
[xUnit.net 00:00:01.37]     Zio.Tests.FileSystems.TestPhysicalFileSystemCompat.TestDirectoryExceptions [FAIL]
[xUnit.net 00:00:01.73]     Zio.Tests.FileSystems.TestPhysicalFileSystem.TestEnumerate [FAIL]
[xUnit.net 00:00:01.76]     Zio.Tests.FileSystems.TestPhysicalFileSystemCompat.TestFile [FAIL]
[xUnit.net 00:00:01.79]     Zio.Tests.FileSystems.TestPhysicalFileSystem.TestFileSystemInvalidDriveLetter [FAIL]
[xUnit.net 00:00:02.35]     Zio.Tests.FileSystems.TestPhysicalFileSystemCompat.TestFileExceptions [FAIL]

GitHub Actions doesn't catch this because the CI only runs on Windows:

https://github.com/xoofx/zio/blob/c23f0a0b822089f14a713482178efe47ce751151/.github/workflows/ci.yml#L14

xoofx commented 5 months ago

Yeah, I didn't bother in the past to make them compatible. I agree that it would be nice. I have actually started to run many of my CI on Ubuntu to speed up CI spin up. PR welcome if you have the courage. ☺️