search

xooniverse / televerse

Your gateway to seamless Telegram Bot Development 💙
https://televerse.xooniverse.com
BSD 3-Clause "New" or "Revised" License
64 stars 11 forks source link

IDs in some methods should be optional #212

Closed Sominemo closed 7 months ago

Sominemo commented 7 months ago

I noticed that methods related to MenuButton have an optional ID field in Telegram API, but televerse uses a non-nullable ID type. Telegram only accepts either a valid ID or absence of the field, so a hack like ID.create("") doesn't work. Absence of the field is used to set default state for the property.

There might be other fields like this one with a similar omission.

image

Sominemo commented 7 months ago

As a side question while I'm on it, is it possible to send a custom request specifying method name and form data? I didn't find a method like it and RawApi seems to be non-extensible. but it would help in blocker cases like this one.

HeySreelal commented 7 months ago

Hey, thanks for reporting! This must be a mistake from my side. As per the documentation the setChatMenuButton method only requires the MenuButton and not the chat_id.

I'll fix this within a couple of hours.

And for the second question, as of now, we don't have a method to make custom request. But it sounds like a good idea as well! Will look into this in the next releases!

HeySreelal commented 7 months ago

Hey @Sominemo, just released v1.13.3 to pub.dev fixing this issue. Thanks again for raising the issue. Please feel free to raise more, or discuss in our Telegram chat, I guess you're already in there! ✨