search

xoopR / distr6

R6 object-oriented interface for probability distributions.
https://xoopr.github.io/distr6/
Other
99 stars 23 forks source link

fix massive bottleneck #296

Closed RaphaelS1 closed 10 months ago

RaphaelS1 commented 11 months ago

Fixes a huge bottleneck in cpp functions for vectorised WeightDisc (includes Matdist and Arrdist)

codecov[bot] commented 11 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (255a666) 88.71% compared to head (dcd1d72) 88.71%.

:exclamation: Current head dcd1d72 differs from pull request most recent head ddef09a. Consider uploading reports for the commit ddef09a to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #296 +/- ## ========================================== - Coverage 88.71% 88.71% -0.01% ========================================== Files 112 112 Lines 9122 9115 -7 ========================================== - Hits 8093 8086 -7 Misses 1029 1029 ``` | [Files](https://app.codecov.io/gh/xoopR/distr6/pull/296?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=xoopR) | Coverage Δ | | |---|---|---| | [R/SDistribution\_Arrdist.R](https://app.codecov.io/gh/xoopR/distr6/pull/296?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=xoopR#diff-Ui9TRGlzdHJpYnV0aW9uX0FycmRpc3QuUg==) | `84.50% <100.00%> (-0.11%)` | :arrow_down: | | [R/SDistribution\_Matdist.R](https://app.codecov.io/gh/xoopR/distr6/pull/296?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=xoopR#diff-Ui9TRGlzdHJpYnV0aW9uX01hdGRpc3QuUg==) | `90.19% <100.00%> (-0.29%)` | :arrow_down: | | [R/SDistribution\_WeightedDiscrete.R](https://app.codecov.io/gh/xoopR/distr6/pull/296?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=xoopR#diff-Ui9TRGlzdHJpYnV0aW9uX1dlaWdodGVkRGlzY3JldGUuUg==) | `90.00% <100.00%> (-0.17%)` | :arrow_down: | | [src/Distributions.cpp](https://app.codecov.io/gh/xoopR/distr6/pull/296?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=xoopR#diff-c3JjL0Rpc3RyaWJ1dGlvbnMuY3Bw) | `92.28% <100.00%> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

jemus42 commented 11 months ago

Any idea why R CMD Check (macOS-latest (release)) is stuck? Is it possible to restart this?

jemus42 commented 11 months ago

The R CMD Check (macOS-latest (release)) job is still "expected", but... hanging?

RaphaelS1 commented 10 months ago

The R CMD Check (macOS-latest (release)) job is still "expected", but... hanging?

Because I have outdated branch protection settings