search

xops / expedition

🧭 A block explorer for the Ethereum stack.
https://expedition.dev/
Apache License 2.0
157 stars 93 forks source link

setting rpc from url no longer works #7

Closed BelfordZ closed 3 years ago

BelfordZ commented 3 years ago

we should be able to set the rpcUrl in a link as follows: https://expedition.dev/?rpcUrl=https://www.ethercluster.com/etc

Since adding the chain list feature, this no longer works because we are missing name & network.

If we add name and network to the url params, then we could add the chain to the list, and when we save to localstorage, it will end up always in the list.

BelfordZ commented 3 years ago

idea from @shanejonas :

if it has no name maybe make it Custom Network

network default to ... Unknown

BelfordZ commented 3 years ago

additionally, if name and network are missing, we could open the 'add chain' modal and have the user add a name and network

dylankilkenny commented 3 years ago

@BelfordZ any update on this? trying to run locally pointed at a local node but it just redirects to ETC.

setting REACT_APP_ETH_RPC_URL also not working

shanejonas commented 3 years ago

:tada: This issue has been resolved in version 1.11.2 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: