This commit fixes several issues. I worked on this prior to thinking abo...

andrewstarks commented 10 years ago

Work started before Planned pushing. The commit message says everything, except that I also hard coded the date string into the log function because I was getting an error, otherwise (complained about %s not being valid for os.date.) I'm not sure if this will hork some larger way that the library works. However, I couldn't make the tests run without this change.

Let me know if you'd like me to redo anything or if something doesn't work. This is my first ever pull request, so please forgive any impolite behavior. :)

andrewstarks commented 10 years ago

I'm going to cancel this pull request and redo it, with individual requests for each, so that you can accept/reject what makes sense to you. Sorry about that, I get over-eager instead of taking time to do it correctly. :P

xopxe commented 10 years ago

Heh, you got me while I was writing a comment. In brief: I agree with everything. What I had written:

'Yep, now that you mention the module naming, I was being pretty careless. It started as a single file project (sched.lua), now it's way beyond that. Blame the "single-developer-syndrome". Respect to the "%s", seems it's a Linux's strftime thing, so you're right and it should stick to something more portable.'

Some comments:

In lib/idle.lua there's function os.capture(cmd, raw) defined, do not see where it is used.
In sched.lua, on lines 13&14 there are requires for lsleep and ls_sleep, probably leftovers?

So, I'll wait for the following Pull requests and act upon them.

xopxe / lumen

This commit fixes several issues. I worked on this prior to thinking abo... #7