Node 4.0.0 support and some goodies.

xorbit / node-aes-gcm

AES GCM module for node.js using OpenSSL

MIT License

34 stars 16 forks source link

Node 4.0.0 support and some goodies. #3

Closed greenboxal closed 8 years ago

greenboxal commented 8 years ago

Added node 4.0.0 support through nan 2.0.9. This caused a lot of changes in how nan is used.

Also:

Added travis-ci support
Added badges to README(already on your user)
Fixed a bug when ciphertext was empty(NIST test case 1).

greenboxal commented 8 years ago

@xorbit I also got a heap corruption on node 0.10 that seems to occur even without my changes. You can see it in action here: https://travis-ci.org/greenboxal/node-aes-gcm/jobs/80033124

I could reproduce it on OS X also, both with my branch and yours.

Have you ever seen that before?

xorbit commented 8 years ago

Thanks so much Jonathan, this looks awesome! :) As for the 0.10 corruption, I hadn't seen this before and it will require some more investigation. But I think the most important thing now is to merge these changes ASAP for 4.0 support. You saved me a lot of work, thanks!

greenboxal commented 8 years ago

Great!

Just as a side note, you need to enable this repository on travis-ci. Also, can you release a new version on npm now? Then I can update my own packages to use it.

xorbit commented 8 years ago

Yep, working on it now. Since I haven't figured out the problem on 0.10, I'm making a couple of changes to indicate it won't work on 0.10, and I'm adding you as a contributor. Then I'll release it to npm.