xorbit / node-aes-gcm

AES GCM module for node.js using OpenSSL
MIT License
34 stars 16 forks source link

upgrades nan to version 2.2.1 #5

Closed normanjoyner closed 8 years ago

normanjoyner commented 8 years ago
gyp ERR! node -v v6.0.0
gyp ERR! node-gyp -v v3.3.1

Installation of the module with the above versions produces the error message below:

> node-gyp rebuild

  CXX(target) Release/obj.target/node_aes_gcm/src/node-aes-gcm.o
In file included from ../src/node-aes-gcm.cc:24:
../node_modules/nan/nan.h:590:20: error: no type named 'GCEpilogueCallback' in 'v8::Isolate'
      v8::Isolate::GCEpilogueCallback callback
      ~~~~~~~~~~~~~^
../node_modules/nan/nan.h:596:20: error: no type named 'GCEpilogueCallback' in 'v8::Isolate'
      v8::Isolate::GCEpilogueCallback callback) {
      ~~~~~~~~~~~~~^
../node_modules/nan/nan.h:601:20: error: no type named 'GCPrologueCallback' in 'v8::Isolate'
      v8::Isolate::GCPrologueCallback callback
      ~~~~~~~~~~~~~^
../node_modules/nan/nan.h:607:20: error: no type named 'GCPrologueCallback' in 'v8::Isolate'
      v8::Isolate::GCPrologueCallback callback) {
      ~~~~~~~~~~~~~^
4 errors generated.
make: *** [Release/obj.target/node_aes_gcm/src/node-aes-gcm.o] Error 1

upgrading nan fixes installation error with newer versions of v8. npm test completes successfully on all 43 tests.

I also tested installation and running tests with the following versions successfully:

It is worth noting that installation fails with node 5.0.0 (which does not currently seem to be the case), and the tests fail with node 0.10.43 (as they currently do).

xorbit commented 8 years ago

Thanks Norman. I went through and brought all dependencies up to date. Any reason why you chose 2.2.1 instead of the newest version 2.3.2?

normanjoyner commented 8 years ago

@xorbit at the time I created the PR 2.2.1 was the latest available. It looks like they bumped to 2.3.x around the same time (https://github.com/nodejs/nan/commit/7a84fbba317aaad47a024971e984efb02d356313). Thanks for updating!