xorbitsai / xorbits

Scalable Python DS & ML, in an API compatible & lightning fast way.
https://xorbits.readthedocs.io
Apache License 2.0
1.13k stars 69 forks source link

BUG: Fix RuntimeError: cannot schedule new futures after shutdown #589

Closed codingl2k1 closed 1 year ago

codingl2k1 commented 1 year ago

What do these changes do?

This error is raised because the thread pool is shutdown in incorrect order. This PR just suppresses errors.

Similar issue: https://github.com/dask/distributed/issues/6087

Related issue number

Fixes #587

Fixed minimal version

Check code requirements

codecov[bot] commented 1 year ago

Codecov Report

Merging #589 (cc1ed3a) into main (b8a1b4d) will increase coverage by 14.18%. The diff coverage is n/a.

@@             Coverage Diff             @@
##             main     #589       +/-   ##
===========================================
+ Coverage   68.49%   82.68%   +14.18%     
===========================================
  Files        1010     1010               
  Lines       78531    78531               
  Branches    16315    16315               
===========================================
+ Hits        53789    64930    +11141     
+ Misses      22572    11897    -10675     
+ Partials     2170     1704      -466     
Flag Coverage Δ
unittests 82.58% <ø> (+14.18%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
python/xorbits/_mars/services/cluster/uploader.py 96.00% <ø> (-2.00%) :arrow_down:

... and 200 files with indirect coverage changes