xorbitsai / xorbits

Scalable Python DS & ML, in an API compatible & lightning fast way.
https://xorbits.readthedocs.io
Apache License 2.0
1.11k stars 67 forks source link

BUG: Fix pre-commit arg and CI node version #622

Closed Flying-Tom closed 1 year ago

Flying-Tom commented 1 year ago

What do these changes do?

Fix pre-commit misused arg and CI node version in GitHub Action

Related issue number

Check code requirements

codecov[bot] commented 1 year ago

Codecov Report

Merging #622 (3e784a9) into main (e74824c) will decrease coverage by 5.84%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #622      +/-   ##
==========================================
- Coverage   75.06%   69.23%   -5.84%     
==========================================
  Files        1022     1022              
  Lines       79235    79235              
  Branches    16437    16437              
==========================================
- Hits        59478    54856    -4622     
- Misses      17247    22137    +4890     
+ Partials     2510     2242     -268     
Flag Coverage Δ
unittests 69.13% <100.00%> (-5.81%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
python/xorbits/_mars/_version.py 37.85% <100.00%> (+2.54%) :arrow_up:

... and 535 files with indirect coverage changes

codingl2k1 commented 1 year ago

According to the doc https://docs.npmjs.com/cli/v8/configuring-npm/package-lock-json

This file is intended to be committed into source repositories

Flying-Tom commented 1 year ago

According to the doc https://docs.npmjs.com/cli/v8/configuring-npm/package-lock-json

This file is intended to be committed into source repositories

The package-lock.json file has been included already.