xorbitsai / xorbits

Scalable Python DS & ML, in an API compatible & lightning fast way.
https://xorbits.readthedocs.io
Apache License 2.0
1.11k stars 67 forks source link

FEAT: Add `xorbits.sklearn` module #716

Closed JiaYaobo closed 11 months ago

JiaYaobo commented 1 year ago

What do these changes do?

This PR aims to export xorbits._mars.learn to xorbits.sklearn

Sub-packages has been added ...

codecov[bot] commented 1 year ago

Codecov Report

Merging #716 (e333bcd) into main (c15148d) will decrease coverage by 0.05%. The diff coverage is 98.93%.

@@            Coverage Diff             @@
##             main     #716      +/-   ##
==========================================
- Coverage   82.49%   82.45%   -0.05%     
==========================================
  Files        1026     1058      +32     
  Lines       79589    79777     +188     
  Branches    16497    16503       +6     
==========================================
+ Hits        65657    65779     +122     
- Misses      11655    11700      +45     
- Partials     2277     2298      +21     
Flag Coverage Δ
unittests 82.33% <98.93%> (-0.04%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
python/xorbits/sklearn/__init__.py 100.00% <100.00%> (ø)
python/xorbits/sklearn/cluster/__init__.py 100.00% <100.00%> (ø)
.../xorbits/sklearn/cluster/mars_adapters/__init__.py 100.00% <100.00%> (ø)
...thon/xorbits/sklearn/cluster/mars_adapters/core.py 100.00% <100.00%> (ø)
python/xorbits/sklearn/datasets/__init__.py 100.00% <100.00%> (ø)
...xorbits/sklearn/datasets/mars_adapters/__init__.py 100.00% <100.00%> (ø)
...hon/xorbits/sklearn/datasets/mars_adapters/core.py 100.00% <100.00%> (ø)
python/xorbits/sklearn/decomposition/__init__.py 100.00% <100.00%> (ø)
...ts/sklearn/decomposition/mars_adapters/__init__.py 100.00% <100.00%> (ø)
...orbits/sklearn/decomposition/mars_adapters/core.py 100.00% <100.00%> (ø)
... and 22 more

... and 28 files with indirect coverage changes

JiaYaobo commented 1 year ago

@aresnow1 @ChengjieLi28 PTAL

aresnow1 commented 12 months ago

Could you rebase main branch and push again?

ChengjieLi28 commented 11 months ago

Hi, @JiaYaobo . On Windows os, there are UT failures in the CI.

image

On windows, the numpy 1.26.1 is installed, which was released two days ago.

Please check whether your UT is compatiable with numpy 1.26.1.

JiaYaobo commented 11 months ago

Hi, @JiaYaobo . On Windows os, there are UT failures in the CI. image

On windows, the numpy 1.26.1 is installed, which was released two days ago.

Please check whether your UT is compatiable with numpy 1.26.1.

numpy 1.26.1 works fine on my macOS, suspecting it's a numpy issue with win32 platform...