Closed JiaYaobo closed 7 months ago
@ChengjieLi28 @UranusSeven @aresnow1 PTAL
https://doc.xorbits.io/en/latest/development/contributing.html#autofixing-formatting-errors
lint fails due to isort, you can either run isort or set up pre commit to auto fix styling issues
Attention: 5 lines
in your changes are missing coverage. Please review.
Comparison is base (
1964357
) 93.59% compared to head (a31297e
) 93.59%.
Files | Patch % | Lines |
---|---|---|
python/xorbits/_mars/tensor/fuse/jax.py | 90.19% | 2 Missing and 3 partials :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
And I think we should add an option for enable JAX
optimization? @JiaYaobo
And I think we should add an option for enable
JAX
optimization? @JiaYaobo
Never mind, we can follow the previous behaviour.
Modify original PR https://github.com/xorbitsai/xorbits/pull/440, which doesn't make full use of the compilation of
jax
,What do these changes do?
this PR re-implements the core
_evaluate
function, referring to https://jax.readthedocs.io/en/latest/autodidax.html#part-2-jaxprs, this PR add a no-recursive and fully jittable_eval
function.Check code requirements