xorbitsai / xorbits

Scalable Python DS & ML, in an API compatible & lightning fast way.
https://xorbits.readthedocs.io
Apache License 2.0
1.11k stars 67 forks source link

BUG: fix read s3 parquet #764

Closed Hank0626 closed 9 months ago

Hank0626 commented 9 months ago

What do these changes do?

Fix the bug of read s3 parquet

Screenshot 2024-01-01 at 22 53 42

Check code requirements

codecov[bot] commented 9 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (de8c809) 93.24% compared to head (3e5427f) 89.06%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #764 +/- ## ========================================== - Coverage 93.24% 89.06% -4.19% ========================================== Files 1059 1059 Lines 79811 79796 -15 Branches 16511 16507 -4 ========================================== - Hits 74421 71069 -3352 - Misses 3658 6889 +3231 - Partials 1732 1838 +106 ``` | [Flag](https://app.codecov.io/gh/xorbitsai/xorbits/pull/764/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=xorbitsai) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/xorbitsai/xorbits/pull/764/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=xorbitsai) | `88.95% <100.00%> (-4.23%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=xorbitsai#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

ChengjieLi28 commented 9 months ago

Have you tried reading a parquet from S3? Does this work when you remove the storage_options?

ChengjieLi28 commented 9 months ago

Have you tried reading a parquet from S3? Does this work when you remove the storage_options?

Paste a screenshot to prove that this PR can work.