Closed luweizheng closed 3 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 85.09%. Comparing base (
d6465c9
) to head (a93e1e5
). Report is 8 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
In the last PR, we added a
parse_config
method in socket channel. This method is mainly for extractinglisten_elastic_ip
inextra_conf
. However, when xorbits calls it, thisconfig
contains keyword arguments likeucx
inextra_conf
. The config will further affect the following code asasyncio.start_server
does not have theucx
keyword argument.In xorbits, this config contains stuff about ucx like:
{'ucx': {'tcp': None, 'nvlink': None, 'infiniband': None, 'rdmacm': None, 'cuda-copy': None, 'create-cuda-contex': None}}
. This config is frompython/xorbits/_mars/deploy/oscar/base_config.yml
.However, SocketChannel does not use the ucx config. So we do not need it here.
Check code requirements