xorbitsai / xoscar

Python actor framework for heterogeneous computing.
https://xoscar.dev
Apache License 2.0
112 stars 23 forks source link

ENH: Fix socket channel config bug #100

Closed luweizheng closed 3 months ago

luweizheng commented 3 months ago

In the last PR, we added a parse_config method in socket channel. This method is mainly for extracting listen_elastic_ip in extra_conf. However, when xorbits calls it, this config contains keyword arguments like ucx in extra_conf. The config will further affect the following code as asyncio.start_server does not have the ucx keyword argument.

aio_server = await asyncio.start_server(
            handle_connection, host=_host, port=port, **config
        )

In xorbits, this config contains stuff about ucx like: {'ucx': {'tcp': None, 'nvlink': None, 'infiniband': None, 'rdmacm': None, 'cuda-copy': None, 'create-cuda-contex': None}}. This config is from python/xorbits/_mars/deploy/oscar/base_config.yml.

However, SocketChannel does not use the ucx config. So we do not need it here.

Check code requirements

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 85.09%. Comparing base (d6465c9) to head (a93e1e5). Report is 8 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #100 +/- ## ========================================== - Coverage 88.97% 85.09% -3.89% ========================================== Files 48 54 +6 Lines 4038 4556 +518 Branches 770 833 +63 ========================================== + Hits 3593 3877 +284 - Misses 358 586 +228 - Partials 87 93 +6 ``` | [Flag](https://app.codecov.io/gh/xorbitsai/xoscar/pull/100/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=xorbitsai) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/xorbitsai/xoscar/pull/100/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=xorbitsai) | `84.92% <ø> (-3.89%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=xorbitsai#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.