xorbitsai / xoscar

Python actor framework for heterogeneous computing.
https://xoscar.dev
Apache License 2.0
91 stars 21 forks source link

ENH: use /tmp/xoscar as default temp dir #13

Closed UranusSeven closed 1 year ago

UranusSeven commented 1 year ago

What do these changes do?

Use /tmp/xoscar as default temp dir

Related issue number

Check code requirements

codecov[bot] commented 1 year ago

Codecov Report

Merging #13 (c96d5f2) into main (6fe27a1) will decrease coverage by 0.04%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #13      +/-   ##
==========================================
- Coverage   91.02%   90.98%   -0.04%     
==========================================
  Files          41       42       +1     
  Lines        3199     3207       +8     
  Branches      641      641              
==========================================
+ Hits         2912     2918       +6     
- Misses        214      215       +1     
- Partials       73       74       +1     
Flag Coverage Δ
unittests 90.83% <100.00%> (-0.04%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
python/xoscar/backends/communication/socket.py 96.78% <100.00%> (-0.87%) :arrow_down:
python/xoscar/constants.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

qianduoduo0904 commented 1 year ago

I am just curious that if it's possible to use the user directory, e.g. ~/xoscar ? and the permission error would not happen in this situation.

UranusSeven commented 1 year ago

I am just curious that if it's possible to use the user directory, e.g. ~/xoscar ? and the permission error would not happen in this situation.

For a standalone deployment, i.e. an xoscar cluster starts from command line, ~/xoscar is OK. But for an embedded deployment, like in Xorbits where user may start an Xorbits local cluster under any dir, you may want a fixed dir for temp files.

qianduoduo0904 commented 1 year ago

I am just curious that if it's possible to use the user directory, e.g. ~/xoscar ? and the permission error would not happen in this situation.

For a standalone deployment, i.e. an xoscar cluster starts from command line, ~/xoscar is OK. But for an embedded deployment, like in Xorbits where user may start an Xorbits local cluster under any dir, you may want a fixed dir for temp files.

Got it.